Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated odh-elyra from 4.1.1 to 4.2.0 #757

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Updated odh-elyra from 4.1.1 to 4.2.0 #757

merged 1 commit into from
Nov 1, 2024
+3,042 −2,944

Conversation

paulovmr
Copy link
Contributor

@paulovmr paulovmr commented Oct 30, 2024 •
edited
Loading

Description

Updated odh-elyra from 4.1.1 to 4.2.0

How Has This Been Tested?

Images generated by the CI were validated.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from caponetto and jiridanek October 30, 2024 15:44
@paulovmr
Copy link
Contributor Author

/retest

@paulovmr
Copy link
Contributor Author

paulovmr commented Nov 1, 2024

I've done the sanity checks with the CI images and it is all good. IMO we can merge this. FYI @harshad16 @jiridanek

jstourac
jstourac reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 1, 2024
harshad16
harshad16 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
👍

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 1, 2024
@paulovmr
Copy link
Contributor Author

paulovmr commented Nov 1, 2024

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/images

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

@paulovmr: Overrode contexts on behalf of paulovmr: ci/prow/images, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests

In response to this:

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit 5629788 into opendatahub-io:main Nov 1, 2024
19 checks passed
@jiridanek jiridanek mentioned this pull request Nov 7, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac left review comments

@harshad16 harshad16 harshad16 approved these changes

@caponetto caponetto Awaiting requested review from caponetto

@jiridanek jiridanek Awaiting requested review from jiridanek

Assignees

@jiridanek jiridanek

@jstourac jstourac

@harshad16 harshad16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulovmr @jiridanek @jstourac @harshad16